Skip to content

Remove VCU128 support #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 15, 2025
Merged

Remove VCU128 support #1795

merged 3 commits into from
Jul 15, 2025

Conversation

sarpadi
Copy link
Contributor

@sarpadi sarpadi commented Jun 26, 2025 •
edited
Loading

VCU128 was discontinued by Xilinx, removing support

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)
  • Documentation

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@sarpadi
ad9081_fmca_ebz: Remove vcu128 support
b577677 
Signed-off-by: sarpadi <sergiu.arpadi@analog.com>
@gastmaier
Copy link
Contributor

There are two mentions of it that should be removed or point to 2023_r2
https://github.com/analogdevicesinc/hdl/blob/remove_vcu128/docs/library/jesd204/index.rst?plain=1#L477
https://github.com/analogdevicesinc/hdl/blob/remove_vcu128/docs/projects/template/index.rst?plain=1#L58-L59

@sarpadi sarpadi force-pushed the remove_vcu128 branch 2 times, most recently from 5d7c93c to 6f8e296 Compare June 27, 2025 12:39
@IuliaCMoldovan IuliaCMoldovan changed the title Remove vcu128 Remove VCU128 support Jul 4, 2025
IuliaCMoldovan
IuliaCMoldovan requested changes Jul 4, 2025
View reviewed changes
@sarpadi sarpadi requested a review from IuliaCMoldovan July 8, 2025 08:27
IuliaCMoldovan
IuliaCMoldovan reviewed Jul 10, 2025
View reviewed changes
gastmaier
gastmaier approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@gastmaier gastmaier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, @IuliaCMoldovan does it resolve your review also?

IuliaCMoldovan
IuliaCMoldovan approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@IuliaCMoldovan IuliaCMoldovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to squash the doc commits before pushing.

sarpadi added 2 commits July 15, 2025 15:29
@sarpadi
ad9081_fmca_ebz: Update project doc
8b63314 
Signed-off-by: sarpadi <sergiu.arpadi@analog.com>
@sarpadi
projects/common: Remove vcu128 support
1761e32 
Signed-off-by: sarpadi <sergiu.arpadi@analog.com>
@sarpadi sarpadi merged commit 4481412 into main Jul 15, 2025
4 checks passed
@sarpadi sarpadi deleted the remove_vcu128 branch July 15, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastmaier gastmaier gastmaier approved these changes

@IuliaCMoldovan IuliaCMoldovan IuliaCMoldovan approved these changes

@StancaPop StancaPop Awaiting requested review from StancaPop StancaPop is a code owner

@LBFFilho LBFFilho Awaiting requested review from LBFFilho LBFFilho is a code owner

@AndrDragomir AndrDragomir Awaiting requested review from AndrDragomir AndrDragomir is a code owner

@FilipG24 FilipG24 Awaiting requested review from FilipG24 FilipG24 is a code owner

@bluncan bluncan Awaiting requested review from bluncan bluncan is a code owner

@acostina acostina Awaiting requested review from acostina acostina is a code owner

@AndreiGrozav AndreiGrozav Awaiting requested review from AndreiGrozav AndreiGrozav is a code owner

@PopPaul2021 PopPaul2021 Awaiting requested review from PopPaul2021 PopPaul2021 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarpadi @gastmaier @IuliaCMoldovan